feat(helm): allow A2A base URL to be set when installing#1162
feat(helm): allow A2A base URL to be set when installing#1162EItanya merged 1 commit intokagent-dev:mainfrom
Conversation
onematchfox
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to configure the A2A (Agent-to-Agent) base URL via Helm chart values, addressing issue #1125. This allows users to specify how the controller service should be addressed by clients connecting to the A2A Server endpoint.
Key Changes:
- Added
a2aBaseUrlconfiguration parameter to the controller section in values.yaml - Configured the
A2A_BASE_URLenvironment variable in the controller ConfigMap - Added comprehensive tests to verify both default and custom URL configurations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| helm/kagent/values.yaml | Adds a2aBaseUrl configuration parameter with default value and documentation |
| helm/kagent/templates/controller-configmap.yaml | Exposes the A2A base URL as an environment variable to the controller |
| helm/kagent/tests/controller-deployment_test.yaml | Adds tests for default and custom A2A base URL values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Linting is failing on a change that was part of #1154. |
onematchfox
force-pushed
the
a2a-base-url
branch
from
eda27dc to
d2dd6b1
Compare
Super weird, do you mind fixing it quick and then we can merge this Later edit: #1165 shouid fix this 🤞 |
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
onematchfox
force-pushed
the
a2a-base-url
branch
from
d2dd6b1 to
6f76d56
Compare
Thanks. Rebased so hopefully everything passes now. |
2 participants
Closes #1125